Remove duplicate ECF variables #31213

ahinzmann · 2020-08-24T13:41:44Z

PR description:

Resolve #31052.
Remove duplicate N2 and N3 variables from MiniAOD.

The duplicate was kept before for backward compatibility with the TWiki (https://twiki.cern.ch/twiki/bin/view/CMSPublic/WorkBookMiniAOD2017#Jets).
The TWiki needs to be updated with this change.

Before this PR, for all AK8 jets with pT<250 GeV 4 values -99999.0 were stored in MiniAOD and NanoAOD. After this PR, those dummy values are not stored anymore MiniAOD, and only kept in NanoAOD for 170<pT<250.

@rappoccio Please check that the code diff makes sense, since you wrote this.

PR validation:

scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport planned.

cmsbuild · 2020-08-24T13:42:06Z

The code-checks are being triggered in jenkins.

rappoccio · 2020-08-24T13:47:42Z

Looks good, I approved them.

cmsbuild · 2020-08-24T13:48:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31213/17862

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/jets_cff.py modified in PR(s): Add ParticleNet to NanoAOD #31096

cmsbuild · 2020-08-24T13:49:00Z

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

PhysicsTools/NanoAOD
PhysicsTools/PatAlgos

@perrotta, @gouskos, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @JyothsnaKomaragiri, @smoortga, @riga, @schoef, @mmarionncern, @peruzzim, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @emilbols, @hatakeyamak, @ferencek, @gpetruc, @andrzejnovak, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-08-24T13:56:07Z

please test

cmsbuild · 2020-08-24T13:56:29Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-24-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8883/console Started: 2020/08/24 15:57

cmsbuild · 2020-08-24T15:19:14Z

-1

Tested at: 330f12c

CMSSW: CMSSW_11_2_X_2020-08-24-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370b92/8883/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

Unit Tests:

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals:

When I ran the RelVals I found an error in the following workflows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

10824.0 step6

runTheMatrix-results/10824.0_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA+Nano/step6_TTbar_13+2018+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+Reco+HARVEST+ALCA+Nano.log

10224.0 step5

runTheMatrix-results/10224.0_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoPU+HARVESTPU+Nano/step5_TTbar_13+2017PU+TTbar_13TeV_TuneCUETP8M1_GenSim+DigiPU+RecoPU+HARVESTPU+Nano.log

cmsbuild · 2020-08-24T15:19:16Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

santocch · 2020-08-29T08:19:56Z

+1

cmsbuild · 2020-08-29T08:20:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-08-29T08:53:05Z

+1

Dr15Jones · 2020-08-30T14:06:32Z

This appears to have broken workflows 136.7722 and 1329.1 in the IBs.

Dr15Jones · 2020-08-30T14:07:23Z

please test workflow 136.7722, 1329.1

cmsbuild · 2020-08-30T14:07:48Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 136.7722,1329.1
CMSSW_11_2_X_2020-08-30-0000/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9006/console Started: 2020/08/30 16:10

cmsbuild · 2020-08-30T15:16:59Z

-1

Tested at: c1494d0

CMSSW: CMSSW_11_2_X_2020-08-30-0000
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-370b92/9006/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
136.7722 step2

runTheMatrix-results/136.7722_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X/step2_RunJetHT2016H_nano+RunJetHT2016H_nano+NANOEDM2016_80X+HARVESTNANOAOD2016_80X.log

1329.1 step2

runTheMatrix-results/1329.1_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X/step2_ZEE_13_80XNanoAODINPUT+ZEE_13_80XNanoAODINPUT+NANOEDMMC2016_80X+HARVESTNANOAODMC2016_80X.log

cmsbuild · 2020-08-30T15:17:01Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

mariadalfonso · 2020-08-30T17:31:25Z

@ahinzmann

the 136.722 and 1329.1 are mini of a type 'run2_miniAOD_80XLegacy'

we should add 'run2_nanoAOD_92X' 'run2_miniAOD_80XLegacy' in the list here
https://github.com/cms-sw/cmssw/pull/31213/files#diff-8255cc2b641b6438258bddebcd7425efR473

ahinzmann added 2 commits August 24, 2020 15:35

remove duplicate ECF

120c941

adapt nanoaod

330f12c

cmsbuild added this to the CMSSW_11_2_X milestone Aug 24, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending xpog-pending labels Aug 24, 2020

rappoccio approved these changes Aug 24, 2020

View reviewed changes

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 24, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 24, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Aug 24, 2020

deal with old miniaods in nanoaod

f3625b3

mariadalfonso mentioned this pull request Aug 24, 2020

features for V8 nanoAOD cms-nanoAOD/cmssw#533

Closed

55 tasks

This was referenced Aug 27, 2020

Shower shape variables for HF jets #31271

Merged

Switch to heavy-ion jets in HI miniAOD #30898

Merged

cmsbuild added analysis-approved and removed analysis-pending pending-signatures labels Aug 29, 2020

cmsbuild added the fully-signed label Aug 29, 2020

cmsbuild added orp-approved and removed orp-pending labels Aug 29, 2020

cmsbuild merged commit c608f77 into cms-sw:master Aug 29, 2020

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Aug 30, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 30, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Aug 30, 2020

ahinzmann mentioned this pull request Aug 31, 2020

Remove duplicate ECF variables (fix old eras) #31303

Merged

mariadalfonso mentioned this pull request Oct 29, 2020

[10_6_X] DDXv2 and BTV changes in Nano #31618, #31786 #31847

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove duplicate ECF variables #31213

Remove duplicate ECF variables #31213

ahinzmann commented Aug 24, 2020 •

edited

Loading

cmsbuild commented Aug 24, 2020

rappoccio commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

perrotta commented Aug 24, 2020

cmsbuild commented Aug 24, 2020 •

edited

Loading

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

santocch commented Aug 29, 2020

cmsbuild commented Aug 29, 2020

qliphy commented Aug 29, 2020

Dr15Jones commented Aug 30, 2020

Dr15Jones commented Aug 30, 2020

cmsbuild commented Aug 30, 2020 •

edited

Loading

cmsbuild commented Aug 30, 2020

cmsbuild commented Aug 30, 2020

mariadalfonso commented Aug 30, 2020

Remove duplicate ECF variables #31213

Remove duplicate ECF variables #31213

Conversation

ahinzmann commented Aug 24, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 24, 2020

rappoccio commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

perrotta commented Aug 24, 2020

cmsbuild commented Aug 24, 2020 • edited Loading

cmsbuild commented Aug 24, 2020

cmsbuild commented Aug 24, 2020

santocch commented Aug 29, 2020

cmsbuild commented Aug 29, 2020

qliphy commented Aug 29, 2020

Dr15Jones commented Aug 30, 2020

Dr15Jones commented Aug 30, 2020

cmsbuild commented Aug 30, 2020 • edited Loading

cmsbuild commented Aug 30, 2020

cmsbuild commented Aug 30, 2020

mariadalfonso commented Aug 30, 2020

ahinzmann commented Aug 24, 2020 •

edited

Loading

cmsbuild commented Aug 24, 2020 •

edited

Loading

cmsbuild commented Aug 30, 2020 •

edited

Loading